fix: memory leak with subdecorations not being disposed#278328
Merged
hediet merged 2 commits intomicrosoft:mainfrom Nov 26, 2025
Merged
fix: memory leak with subdecorations not being disposed#278328hediet merged 2 commits intomicrosoft:mainfrom
hediet merged 2 commits intomicrosoft:mainfrom
Conversation
SimonSiefke
changed the title
SimonSiefke
changed the title
SimonSiefke
changed the title
SimonSiefke
changed the title
hediet
approved these changes
Nov 24, 2025
Member
|
Thanks for discovering and fixing this! |
Tyriar
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak with subdecoration types not being disposed when a decoration type is disposed.
Before
When registering / unregistering decorations for example by toggling git inline blame, the number of CSS rules seems to grow by one each time.
Toggling git inline blame 97 times, the number of CSS rules grows by 97:
The added CSS rules all look like this:
{ "cssRules": { "leaked": [ /* many more */ ".monaco-editor .ced-1-TextEditorDecorationType142--92456b-4.ced-1-TextEditorDecorationType142-4::after { content: \"first commit\"; margin: 0px 0px 0px 50px; }", ".monaco-editor .ced-1-TextEditorDecorationType127--92456b-4.ced-1-TextEditorDecorationType127-4::after { content: \"first commit\"; margin: 0px 0px 0px 50px; }", ".monaco-editor .ced-1-TextEditorDecorationType112--92456b-4.ced-1-TextEditorDecorationType112-4::after { content: \"first commit\"; margin: 0px 0px 0px 50px; }", ".monaco-editor .ced-1-TextEditorDecorationType97--92456b-4.ced-1-TextEditorDecorationType97-4::after { content: \"first commit\"; margin: 0px 0px 0px 50px; }", ".monaco-editor .ced-1-TextEditorDecorationType82--92456b-4.ced-1-TextEditorDecorationType82-4::after { content: \"first commit\"; margin: 0px 0px 0px 50px; }", ".monaco-editor .ced-1-TextEditorDecorationType67--92456b-4.ced-1-TextEditorDecorationType67-4::after { content: \"first commit\"; margin: 0px 0px 0px 50px; }", ".monaco-editor .ced-1-TextEditorDecorationType52--92456b-4.ced-1-TextEditorDecorationType52-4::after { content: \"first commit\"; margin: 0px 0px 0px 50px; }" ] }, "isLeak": false }After
No more leak is detected.