mcp: implement sep-1732 tasks #277888
Merged
mcp: implement sep-1732 tasks #277888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement full support for both server-side and client-side tasks on tool calls, sampling, and elicitation Refs modelcontextprotocol/modelcontextprotocol#1732
connor4312
force-pushed
the
connor4312/mcp-tasks
branch
from
a9f13f0 to
582ef94
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements full support for MCP tasks as specified in SEP-1732, enabling both server-side and client-side task-augmented execution for tool calls, sampling, and elicitation requests.
Key Changes
- Adds comprehensive task management infrastructure with
McpTaskManagerfor handling asynchronous task execution, polling, and lifecycle management - Updates the MCP protocol schema to include task-related types, requests, and notifications
- Implements task-augmented request handling for
tools/call,sampling/createMessage, andelicitation/createoperations
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| modelContextProtocol.ts | Extensive protocol schema updates including new task types, parameters, requests/responses, and capability negotiation fields |
| mcpTaskManager.ts | New task manager implementation for managing server-side and client-side task state, execution, and lifecycle |
| mcpServerRequestHandler.ts | Adds task augmentation support, client task tracking, polling implementation, and task-related request handlers |
| mcpServerConnection.ts | Integrates task manager into server connections for persistence across reconnections |
| mcpServer.ts | Adds shared task manager instance and implements task hints for tool calls |
| mcpSamplingService.ts | Updates message content handling to support arrays using asArray utility |
| mcpTypes.ts | Updates handler signatures to accept optional CancellationToken parameters |
| mcpTypesUtils.ts | Adds isTaskResult type guard utility |
| mcpRegistry.ts | Threads task manager through connection creation |
| mcpRegistryTypes.ts | Adds task manager to connection options |
| mcpIcons.ts | Adds backward compatibility for icon sizes as strings |
| mcpSamplingLog.test.ts | Updates test assertions to handle array content using asArray |
| mcpIcons.test.ts | Updates test data to use array format for icon sizes |
| mcpServerConnection.test.ts | Adds task manager instances to all test connection creations |
| mcpServerRequestHandler.test.ts | Adds task manager to handler creation in tests |
| chatToolOutputWebviewSubPart.ts | New file for rendering tool outputs using webviews (appears unrelated to tasks) |
TylerLeonhardt
approved these changes
Nov 26, 2025
| } | ||
|
|
||
| export function isTaskResult(obj: MCP.Result | MCP.CreateTaskResult): obj is MCP.CreateTaskResult { | ||
| return (obj as MCP.CreateTaskResult).task !== undefined; |
|
Cool! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement full support for both server-side and client-side tasks on tool calls, sampling, and elicitation
Refs modelcontextprotocol/modelcontextprotocol#1732