fix: memory leak in startup page#277199
Merged
bpasero merged 1 commit intomicrosoft:mainfrom Nov 24, 2025
Merged
Conversation
bpasero
approved these changes
Nov 24, 2025
deepak1556
approved these changes
Nov 24, 2025
bhavyaus
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a memory leak in startup page.
There only seems to be one global
StartupPageEditorResolverContributioninstance. Registering disposables to the class adds them to that instance, but being a global instance instance, the disposables are never disposed.Before
When opening and closing a getting started editor, the number GettingStartedInputs grows each time:
After
No more leaks are detected
{ "namedFunctionCount3": [], "isLeak": false }