mcp: adopt sep-1330 for enhanced enum picks #276963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Nov 12, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adopts SEP-1330 to enhance enum picker support in the MCP (Model Context Protocol) implementation. It introduces a JSON Schema 2020-12 compliant approach for enum schemas with display titles, replacing the non-standard enumNames property.
Key changes:
- Splits enum schema definitions into single-select and multi-select variants, each with titled and untitled options
- Introduces
oneOfwithconst/titlefor single-select andanyOfwithconst/titlefor multi-select enums - Maintains backward compatibility with the legacy
enumNamespattern
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/mcp/common/modelContextProtocol.ts | Defines new schema interfaces for single-select, multi-select, titled, and untitled enum schemas, plus legacy support |
| src/vs/workbench/contrib/mcp/browser/mcpElicitationService.ts | Implements type guards and handlers for the new enum schema types, including a new multi-select enum field handler |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs modelcontextprotocol/modelcontextprotocol#1148