Skip to content

fix: memory leak in terminal process (partially)#276962

Merged
Tyriar merged 2 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-terminal-process
Nov 12, 2025
Merged

fix: memory leak in terminal process (partially)#276962
Tyriar merged 2 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-terminal-process

Conversation

@SimonSiefke
Copy link
Contributor

Related to #276958. Registering three disposables, similar to how other disposables are registered.

Results

Results still show the same promise memory leak as before. So it seems like there could still be other leaks somewhere related to this promise:

this._processStartupComplete = new Promise<void>(c => {
  this.onProcessReady(() => c());
});

@Tyriar Tyriar added this to the November 2025 milestone Nov 12, 2025
@Tyriar Tyriar enabled auto-merge November 12, 2025 18:54
@Tyriar Tyriar merged commit d4ab0fd into microsoft:main Nov 12, 2025
17 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 27, 2025
@SimonSiefke SimonSiefke deleted the fix/memory-leak-terminal-process branch January 15, 2026 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants