Skip to content

settings cleanup#276602

Merged
justschen merged 1 commit intomicrosoft:mainfrom
justschen:justin/wormadam-plant
Nov 10, 2025
Merged

settings cleanup#276602
justschen merged 1 commit intomicrosoft:mainfrom
justschen:justin/wormadam-plant

Conversation

@justschen
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings November 10, 2025 21:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR promotes several chat-related settings from experimental status by either removing the 'experimental' tag entirely or changing it to 'preview', indicating these features have matured and are ready for broader use.

Key changes:

  • Removes 'experimental' tags from implicit context settings that are now stable
  • Changes 'experimental' to 'preview' for sendElementsToChat and emptyState.history settings
  • Removes 'experimental' tag from undoRequests.restoreInput setting
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/chat.contribution.ts:294

  • The setting 'chat.sendElementsToChat.attachImages' still has the 'experimental' tag, while the related settings 'chat.sendElementsToChat.enabled' and 'chat.sendElementsToChat.attachCSS' have been updated to 'preview'. For consistency, this setting should likely also be updated to 'preview' unless there's a specific reason it should remain experimental.
		'chat.sendElementsToChat.attachImages': {
			default: true,
			markdownDescription: nls.localize('chat.sendElementsToChat.attachImages', "Controls whether a screenshot of the selected element will be added to the chat. {0} must be enabled.", '`#chat.sendElementsToChat.enabled#`'),
			type: 'boolean',
			tags: ['experimental']
		},

@justschen justschen marked this pull request as ready for review November 10, 2025 21:55
@vs-code-engineering vs-code-engineering bot added this to the November 2025 milestone Nov 10, 2025
@justschen justschen merged commit 2ac4ed9 into microsoft:main Nov 10, 2025
22 of 23 checks passed
Kosta-Github added a commit to Kosta-Github/vscode that referenced this pull request Nov 11, 2025
…nal-tooltips-markdown

* 'main' of https://github.com/microsoft/vscode: (56 commits)
  edits: show diff for sensitive edit confirmations (microsoft#276620)
  Enable Back button on the Manage Accounts picker (microsoft#276622)
  Ignore obsolete chat content parts when loading persisted session (microsoft#276615)
  settings cleanup (microsoft#276602)
  Remove unused `args: any` parameter
  Terminal suggest - include persistent options in suggestions and improve suggestion grouping (microsoft#276409)
  fix selections not being added (microsoft#276600)
  Embed AI search into the existing search view message (microsoft#276586)
  Cleanup some eslint exemptions (microsoft#276581)
  fix microsoft#276579 (microsoft#276590)
  SCM - cleanup some more eslint rules (microsoft#276571)
  Bump gpu types and skip lib check for gpu typing issue
  Fix in smoke tests
  Remove `forChatSessionTypeAndId`
  Fix one more import
  detect `press any/a key` and ask if user wants to send `a` to terminal (microsoft#276554)
  Filter subagent and todo tools from subagent requests (microsoft#276553)
  Expand hover setting to allow for key modifier mode (microsoft#274001)
  Allow partial monacoEnvironment.getWorker/getWorkerUrl
  Update imports
  ...
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants