fix: memory leak in breadcrumbs#276597
Merged
jrieken merged 1 commit intomicrosoft:mainfrom Nov 11, 2025
Merged
Conversation
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Member
|
@SimonSiefke thank you, I see more usages of vscode/src/vs/workbench/browser/parts/editor/breadcrumbsControl.ts Lines 708 to 709 in e75b176 Moving to @jrieken for review |
lszomoru
approved these changes
Nov 11, 2025
Contributor
Author
|
@bpasero Thanks. Great catch! There is a also test for editor toggle breadcrumbs, so there seems to be a leak still 
|
Member
|
Feel free to open PR for it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
When opening and closing the Markdown Preview, the number of breadcrumb functions grows each time, https://simonsiefke.github.io/vscode-memory-leak-finder/named-function-count-3/
After
When opening and closing the Markdown Preview, the number of breadcrumb functions stays constant.