Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #276579 by adding URI encoding to the name parameter in the getLatestServerVersionUrl method to properly handle special characters when constructing URLs.
- Applies
encodeURIComponentto thenameparameter before passing it to the URI template
Comments suppressed due to low confidence (3)
src/vs/platform/mcp/common/mcpGalleryService.ts:1022
- The
nameparameter should be URI-encoded usingencodeURIComponent(name)to handle special characters consistently withgetLatestServerVersionUrlon line 1038. Server names with special characters could result in malformed URLs.
return format2(namedResourceUriTemplate, { name });
src/vs/platform/mcp/common/mcpGalleryService.ts:1046
- The
nameparameter should be URI-encoded usingencodeURIComponent(name)to handle special characters consistently withgetLatestServerVersionUrlon line 1038. Server names with special characters could result in malformed URLs.
return format2(resourceUriTemplate, { name });
src/vs/platform/mcp/common/mcpGalleryService.ts:1054
- The
nameparameter should be URI-encoded usingencodeURIComponent(name)to handle special characters consistently withgetLatestServerVersionUrlon line 1038. Publisher names with special characters could result in malformed URLs.
return format2(resourceUriTemplate, { name });
Tyriar
approved these changes
Nov 10, 2025
Kosta-Github
added a commit
to Kosta-Github/vscode
that referenced
this pull request
Nov 11, 2025
…nal-tooltips-markdown * 'main' of https://github.com/microsoft/vscode: (56 commits) edits: show diff for sensitive edit confirmations (microsoft#276620) Enable Back button on the Manage Accounts picker (microsoft#276622) Ignore obsolete chat content parts when loading persisted session (microsoft#276615) settings cleanup (microsoft#276602) Remove unused `args: any` parameter Terminal suggest - include persistent options in suggestions and improve suggestion grouping (microsoft#276409) fix selections not being added (microsoft#276600) Embed AI search into the existing search view message (microsoft#276586) Cleanup some eslint exemptions (microsoft#276581) fix microsoft#276579 (microsoft#276590) SCM - cleanup some more eslint rules (microsoft#276571) Bump gpu types and skip lib check for gpu typing issue Fix in smoke tests Remove `forChatSessionTypeAndId` Fix one more import detect `press any/a key` and ask if user wants to send `a` to terminal (microsoft#276554) Filter subagent and todo tools from subagent requests (microsoft#276553) Expand hover setting to allow for key modifier mode (microsoft#274001) Allow partial monacoEnvironment.getWorker/getWorkerUrl Update imports ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #276579