undo finalization of terminal completion provider API#276174
Merged
meganrogge merged 1 commit intomainfrom Nov 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR moves the Terminal Completion Provider API from the stable API surface (vscode.d.ts) to a proposed API (vscode.proposed.terminalCompletionProvider.d.ts), properly gating it behind the terminalCompletionProvider proposal flag. This change also includes a minor documentation update where "master" is changed to "main" in an example.
- Moves terminal completion API definitions to a new proposed API file
- Adds proper API gating checks in extension host and contribution service
- Registers the new API proposal with correct URL
- Updates the terminal-suggest extension to opt-in to the proposed API
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.terminalCompletionProvider.d.ts | New proposed API file containing all terminal completion provider types and interfaces |
| src/vscode-dts/vscode.d.ts | Removes terminal completion API definitions from stable API surface |
| src/vs/workbench/contrib/terminal/common/terminalExtensionPoints.ts | Adds proposal check for terminal completion providers in contributions |
| src/vs/workbench/api/common/extHost.api.impl.ts | Adds proposal check when registering terminal completion providers |
| src/vs/platform/extensions/common/extensionsApiProposals.ts | Registers the new terminalCompletionProvider proposal |
| extensions/terminal-suggest/package.json | Adds terminalCompletionProvider to enabled API proposals |
mjbvz
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #276142 in main