Use legacy lookup for chat session#276170
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Nov 7, 2025
Merged
Conversation
Fixes microsoft#276167 Workaround until we get proper fix as part of microsoft#274403
rzhao271
approved these changes
Nov 7, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the session lookup in languageModelToolsService.ts to use the newer getSessionByLegacyId() method instead of constructing a URI with LocalChatSessionUri.forSession().
- Removes unnecessary URI construction when looking up chat sessions by their string ID
- Simplifies the code by directly using
getSessionByLegacyId()which accepts a string session ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #276167
Workaround until we get proper fix as part of #274403