Revert "macOS - restore use of hide and show for app.dock second instances"
#275876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d instan…" This reverts commit ab8380f.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @deepak1556Matched files:
|
Tyriar
approved these changes
Nov 6, 2025
rzhao271
approved these changes
Nov 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes macOS dock visibility management code from the main process startup logic. The changes eliminate dock hide/show calls that were previously used when handling multiple VS Code instances.
- Removes dock.hide() call when detecting a second instance is running
- Removes dock.show() call when successfully claiming instance ownership
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #259883
fix #274146