Support loading system certificates with Node#274631
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for loading system certificates using Node.js built-in TLS API (tls.getCACertificates('system')) as an alternative to the existing @vscode/proxy-agent implementation. The feature is controlled by a new experimental setting http.systemCertificatesNode.
- Introduces a new configuration option
http.systemCertificatesNode(default: false, experimental) - Updates certificate loading logic in both
RequestServiceandproxyResolverto use Node.js native API when enabled - Updates
@types/nodeto version^22.18.10to support the new TLS API
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/request/common/request.ts | Adds http.systemCertificatesNode setting configuration and includes it in USER_LOCAL_AND_REMOTE_SETTINGS |
| src/vs/platform/request/node/requestService.ts | Implements Node.js-based certificate loading in loadCertificates() method and updates getConfigValue() to support fallback values |
| src/vs/workbench/api/node/proxyResolver.ts | Updates loadAdditionalCertificates to use Node.js system certificates for both remote and local scenarios when the setting is enabled |
| package.json | Updates @types/node dependency to ^22.18.10 |
| package-lock.json | Updates lockfile for @types/node and its dependency undici-types |
justschen
previously approved these changes
Nov 2, 2025
Collaborator
|
@chrmarti looks like compile/hygiene failed |
chrmarti
force-pushed
the
chrmarti/bad-badger
branch
from
089ec4c to
0cf6b7c
Compare
chrmarti
force-pushed
the
chrmarti/bad-badger
branch
from
0cf6b7c to
2197b31
Compare
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
connor4312
approved these changes
Nov 2, 2025
This was referenced Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#252148