Conversation
This adds basic language support for the dotenv language. This includes syntax highlighting and a language configuration file. The dotenv language is applied to files with the `.env` extension, files named `.env`, `.flaskenv`, or `user-dirs.dirs`, and file names starting with `.env.`. The grammar is downloaded from https://github.com/dotenv-org/dotenv-vscode. Closes microsoft#267333
|
I’m not sure if I’m also supposed to update |
|
@remcohaszing I'm seeing a schema validation issue in language-configuration.json: 
|
|
I noticed this too. It’s a bug in the JSON schema. This affects all |
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have a few comments. Not sure if we want to conflict with shellscript and ini.
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Alright, one last question: why is this change better than using the existing shellscript grammar to highlight dotenv files?
|
Dotenv is a strict subset. Only variable assignments and comments are allowed. You can also use the TypeScript grammar to highlight JavaScript files, or the TypeScript, JavaScript, or YAML grammar to highlight JSON files. Their results would be fine, as long as the content is valid JSON. Besides syntax highlighting it’s nice to have a builtin defined language ID that extensions can hook into. For example Given your question and the loose ressemblence based on which dotenv files were marked as |
|
@microsoft-github-policy-service rerun |
5 participants
This adds basic language support for the dotenv language. This includes syntax highlighting and a language configuration file.
The dotenv language is applied to files with the
.envextension, files named.env,.flaskenv, oruser-dirs.dirs, and file names starting with.env..The grammar is downloaded from https://github.com/dotenv-org/dotenv-vscode.
Closes #267333
Closes #267355