Fix terminal tab prompt input breaking when backticks are included by Abrifq · Pull Request #272425 · microsoft/vscode

Abrifq · 2025-10-21T07:46:08Z

Closes #272416.
I have tested the changes manually via codespaces.

Abrifq

OoT/pet peeve:
Prompt input sometimes gets an extra space appended.

Need to check _doSync() for what could cause it:

vscode/src/vs/platform/terminal/common/capabilities/commandDetection/promptInputModel.ts

Lines 273 to 449 in 55505bf

    
           private _doSync() { 
        
           	if (this._state !== PromptInputState.Input) { 
        
           		return; 
        
           	} 
        
           	let commandStartY = this._commandStartMarker?.line; 
        
           	if (commandStartY === undefined) { 
        
           		return; 
        
           	} 
        
           	const buffer = this._xterm.buffer.active; 
        
           	let line = buffer.getLine(commandStartY); 
        
           	const absoluteCursorY = buffer.baseY + buffer.cursorY; 
        
           	let cursorIndex: number | undefined; 
        
           	let commandLine = line?.translateToString(true, this._commandStartX); 
        
           	if (this._shellType === PosixShellType.Fish && (!line || !commandLine)) { 
        
           		commandStartY += 1; 
        
           		line = buffer.getLine(commandStartY); 
        
           		if (line) { 
        
           			commandLine = line.translateToString(true); 
        
           			cursorIndex = absoluteCursorY === commandStartY ? buffer.cursorX : commandLine?.trimEnd().length; 
        
           		} 
        
           	} 
        
           	if (line === undefined || commandLine === undefined) { 
        
           		this._logService.trace(`PromptInputModel#_sync: no line`); 
        
           		return; 
        
           	} 
        
           	let value = commandLine; 
        
           	let ghostTextIndex = -1; 
        
           	if (cursorIndex === undefined) { 
        
           		if (absoluteCursorY === commandStartY) { 
        
           			cursorIndex = Math.min(this._getRelativeCursorIndex(this._commandStartX, buffer, line), commandLine.length); 
        
           		} else { 
        
           			cursorIndex = commandLine.trimEnd().length; 
        
           		} 
        
           	} 
        
           	// From command start line to cursor line 
        
           	for (let y = commandStartY + 1; y <= absoluteCursorY; y++) { 
        
           		const nextLine = buffer.getLine(y); 
        
           		const lineText = nextLine?.translateToString(true); 
        
           		if (lineText && nextLine) { 
        
           			// Check if the line wrapped without a new line (continuation) or 
        
           			// we're on the last line and the continuation prompt is not present, so we need to add the value 
        
           			if (nextLine.isWrapped || (absoluteCursorY === y && this._continuationPrompt && !this._lineContainsContinuationPrompt(lineText))) { 
        
           				value += `${lineText}`; 
        
           				const relativeCursorIndex = this._getRelativeCursorIndex(0, buffer, nextLine); 
        
           				if (absoluteCursorY === y) { 
        
           					cursorIndex += relativeCursorIndex; 
        
           				} else { 
        
           					cursorIndex += lineText.length; 
        
           				} 
        
           			} else if (this._shellType === PosixShellType.Fish) { 
        
           				if (value.endsWith('\\')) { 
        
           					// Trim off the trailing backslash 
        
           					value = value.substring(0, value.length - 1); 
        
           					value += `${lineText.trim()}`; 
        
           					cursorIndex += lineText.trim().length - 1; 
        
           				} else { 
        
           					if (/^ {6,}/.test(lineText)) { 
        
           						// Was likely a new line 
        
           						value += `\n${lineText.trim()}`; 
        
           						cursorIndex += lineText.trim().length + 1; 
        
           					} else { 
        
           						value += lineText; 
        
           						cursorIndex += lineText.length; 
        
           					} 
        
           				} 
        
           			} 
        
           			// Verify continuation prompt if we have it, if this line doesn't have it then the 
        
           			// user likely just pressed enter. 
        
           			else if (this._continuationPrompt === undefined || this._lineContainsContinuationPrompt(lineText)) { 
        
           				const trimmedLineText = this._trimContinuationPrompt(lineText); 
        
           				value += `\n${trimmedLineText}`; 
        
           				if (absoluteCursorY === y) { 
        
           					const continuationCellWidth = this._getContinuationPromptCellWidth(nextLine, lineText); 
        
           					const relativeCursorIndex = this._getRelativeCursorIndex(continuationCellWidth, buffer, nextLine); 
        
           					cursorIndex += relativeCursorIndex + 1; 
        
           				} else { 
        
           					cursorIndex += trimmedLineText.length + 1; 
        
           				} 
        
           			} 
        
           		} 
        
           	} 
        
           	// Below cursor line 
        
           	for (let y = absoluteCursorY + 1; y < buffer.baseY + this._xterm.rows; y++) { 
        
           		const belowCursorLine = buffer.getLine(y); 
        
           		const lineText = belowCursorLine?.translateToString(true); 
        
           		if (lineText && belowCursorLine) { 
        
           			if (this._shellType === PosixShellType.Fish) { 
        
           				value += `${lineText}`; 
        
           			} else if (this._continuationPrompt === undefined || this._lineContainsContinuationPrompt(lineText)) { 
        
           				value += `\n${this._trimContinuationPrompt(lineText)}`; 
        
           			} else { 
        
           				value += lineText; 
        
           			} 
        
           		} else { 
        
           			break; 
        
           		} 
        
           	} 
        
           	if (this._logService.getLevel() === LogLevel.Trace) { 
        
           		this._logService.trace(`PromptInputModel#_sync: ${this.getCombinedString()}`); 
        
           	} 
        
           	// Adjust trailing whitespace 
        
           	{ 
        
           		let trailingWhitespace = this._value.length - this._value.trimEnd().length; 
        
           		// Handle backspace key 
        
           		if (this._lastUserInput === '\x7F') { 
        
           			this._lastUserInput = ''; 
        
           			if (cursorIndex === this._cursorIndex - 1) { 
        
           				// If trailing whitespace is being increased by removing a non-whitespace character 
        
           				if (this._value.trimEnd().length > value.trimEnd().length && value.trimEnd().length <= cursorIndex) { 
        
           					trailingWhitespace = Math.max((this._value.length - 1) - value.trimEnd().length, 0); 
        
           				} 
        
           				// Standard case; subtract from trailing whitespace 
        
           				else { 
        
           					trailingWhitespace = Math.max(trailingWhitespace - 1, 0); 
        
           				} 
        
           			} 
        
           		} 
        
           		// Handle delete key 
        
           		if (this._lastUserInput === '\x1b[3~') { 
        
           			this._lastUserInput = ''; 
        
           			if (cursorIndex === this._cursorIndex) { 
        
           				trailingWhitespace = Math.max(trailingWhitespace - 1, 0); 
        
           			} 
        
           		} 
        
           		const valueLines = value.split('\n'); 
        
           		const isMultiLine = valueLines.length > 1; 
        
           		const valueEndTrimmed = value.trimEnd(); 
        
           		if (!isMultiLine) { 
        
           			// Adjust trimmed whitespace value based on cursor position 
        
           			if (valueEndTrimmed.length < value.length) { 
        
           				// Handle space key 
        
           				if (this._lastUserInput === ' ') { 
        
           					this._lastUserInput = ''; 
        
           					if (cursorIndex > valueEndTrimmed.length && cursorIndex > this._cursorIndex) { 
        
           						trailingWhitespace++; 
        
           					} 
        
           				} 
        
           				trailingWhitespace = Math.max(cursorIndex - valueEndTrimmed.length, trailingWhitespace, 0); 
        
           			} 
        
           			// Handle case where a non-space character is inserted in the middle of trailing whitespace 
        
           			const charBeforeCursor = cursorIndex === 0 ? '' : value[cursorIndex - 1]; 
        
           			if (trailingWhitespace > 0 && cursorIndex === this._cursorIndex + 1 && this._lastUserInput !== '' && charBeforeCursor !== ' ') { 
        
           				trailingWhitespace = this._value.length - this._cursorIndex; 
        
           			} 
        
           		} 
        
           		if (isMultiLine) { 
        
           			valueLines[valueLines.length - 1] = valueLines.at(-1)?.trimEnd() ?? ''; 
        
           			const continuationOffset = (valueLines.length - 1) * (this._continuationPrompt?.length ?? 0); 
        
           			trailingWhitespace = Math.max(0, cursorIndex - value.length - continuationOffset); 
        
           		} 
        
           		value = valueLines.map(e => e.trimEnd()).join('\n') + ' '.repeat(trailingWhitespace); 
        
           	} 
        
           	ghostTextIndex = this._scanForGhostText(buffer, line, cursorIndex); 
        
           	if (this._value !== value || this._cursorIndex !== cursorIndex || this._ghostTextIndex !== ghostTextIndex) { 
        
           		this._value = value; 
        
           		this._cursorIndex = cursorIndex; 
        
           		this._ghostTextIndex = ghostTextIndex; 
        
           		this._onDidChangeInput.fire(this._createStateObject()); 
        
           	} 
        
           }

Abrifq · 2025-10-22T09:58:37Z

Hi, I have tested my PR within codespaces' VNC, it does work now.

I had to enable supportHtml to wrap with <code> though, so you may want to check if another input could inject links/html.

vscode/src/vs/workbench/contrib/terminal/browser/terminalTooltip.ts

Lines 46 to 49 in 5e797a9

    
           const shellProcessString = getShellProcessTooltip(instance, !!showDetailed); 
        
           const content = new MarkdownString(instance.title + shellProcessString + statusString, { supportThemeIcons: true, supportHtml: true }); 
        
           return { content, actions };

Prompt input sometimes gets an extra space appended.

There might be a desync causing this, needs more investigation. As I started that comment, it is out of topic.

meganrogge · 2025-10-27T13:26:44Z

Thanks for the PR. Can you pls provide a screenshot of this working for you in testing?

Abrifq · 2025-10-28T06:11:04Z

Update:

Prefixing backslashes to backticks makes them show up again.
However, I think I'll have to escape most of the markdown characters because I can still escape things out:

I'll also check if just applying db999f4 onto main works.

Abrifq · 2025-10-28T06:58:08Z

I will send the patch in after also testing with links with titles, but here is how it looks right now:

If there is any other markdown escapes you would like me to check, I'll happily test but for now I changed the code to:

If there are any < or >, which could cause html injections, they are replaced with < and >.
If there is a markdown link, the link part gets wrapped with < and >, as escaping in step 3 will add a ) to the link's end.
Escape [, ], (, ), -, *, !, # and ` characters by prefixing with backslashes, as markdown renderer doesn't skip markdown in <code> elements. (Maybe sub-issue?)

I thought your issue was backticks only. Why are you escaping everything else?

That was my first thought but I now realized I should be able to see what I wrote as visually unchanged as possible on the detail popup.

Abrifq · 2025-10-28T08:32:24Z

I will send the patch in after also testing with links with titles

I have tested (https://regexr.com/8hu9f) and it should be good for now.

Testing with this input:

echo `date`; echo </code>[escaped link?](https://youtu.be/dQw4w9WgXcQ "asdasdasd")

Main Branch (`124710c`)

My patch (`3ccfea3`)

Abrifq · 2025-10-28T08:51:15Z

I'll also check if just applying db999f4 onto main works.

It does not. Until someone confirms that markdown rendering inside <code> is a bug and gets that fixed, this seems like the best solution.

If I didn't misread the code when I first opened this issue/PR, the changes I made should run once per keystroke, so it should -hopefully- have only negligible performance impacts.

Abrifq · 2025-11-03T11:28:28Z

I guess feature release from Github Universe could have created some urgent backlog but is there anything blocking this PR from being reviewed?

Edit: Well, the Monthly Endgame has started. Oh well.

Abrifq · 2025-11-12T11:14:41Z

Hello @meganrogge, while waiting for this PR to get reviewed, should I update the base branch to test against newer base or should I leave as is?

I'm asking this in general, it's not mentioned in contributing guide.

meganrogge · 2025-11-12T13:50:42Z

src/vs/workbench/contrib/terminal/browser/terminalTooltip.ts


 	const shellProcessString = getShellProcessTooltip(instance, !!showDetailed);
-	const content = new MarkdownString(instance.title + shellProcessString + statusString, { supportThemeIcons: true });
+	const content = new MarkdownString(instance.title + shellProcessString + statusString, { supportThemeIcons: true, supportHtml: true });


Why do we need to supportHtml here to fix this?

Current markdown parsing doesn't allow for escaping backticks via a backslash, and to workaround that I have changed the backtick wrapping with <code> wrapping.

Code wrapping does not work unless supportHtml is enabled, though. Which is why I enabled it.

src/vs/workbench/contrib/terminal/browser/terminalTooltip.ts

Tyriar · 2025-11-12T17:58:35Z

src/vs/workbench/contrib/terminal/browser/terminalTooltip.ts

+		const escapedPromptInput = combinedString
+			.replaceAll('<', '&lt;').replaceAll('>', '&gt;') 		 //Prevent escaping from wrapping
+			.replaceAll(/\((.+?)(\|?(?: (?:.+?)?)?)\)/g, '(<$1>$2)') //Escape links as clickable links
+			.replaceAll(/([\[\]\(\)\-\*\!\#\`])/g, '\\$1'); 		 //Comment most of the markdown elements to not render them inside
+		detailedAdditions.push(`Prompt input: <code>\n${escapedPromptInput}\n</code>`);


isn't this just as simple as escaping inner backticks like this?

combinedString.replaceAll('`', '\\`')

I have tried it and it didn't work that time
( #272425 (comment) )

https://github.com/Abrifq/vscode/tree/Abrifq/alt-wrap-fix

But I will update the branch & try again and report here.

The current proposal seems far too complex for what this actually does imo, all it's doing is making debug information show a little nicer. Does this helper do the job?

vscode/src/vs/base/common/htmlContent.ts

Lines 153 to 156 in 1d4fe40

export function escapeMarkdownSyntaxTokens(text: string): string {

// escape markdown syntax tokens: http://daringfireball.net/projects/markdown/syntax#backslash

return text.replace(/[\\`*_{}[\]()#+\-!~]/g, '\\$&'); // CodeQL [SM02383] Backslash is escaped in the character class

}

Does this helper do the job?

vscode/src/vs/base/common/htmlContent.ts

Lines 153 to 156 in 1d4fe40

export function escapeMarkdownSyntaxTokens(text: string): string {

// escape markdown syntax tokens: http://daringfireball.net/projects/markdown/syntax#backslash

return text.replace(/[\\`*_{}[\]()#+\-!~]/g, '\\$&'); // CodeQL [SM02383] Backslash is escaped in the character class

}

Yeah, it should replace line 115. Thanks!

The current proposal seems far too complex for what this actually does imo, all it's doing is making debug information show a little nicer.

I need to check if lines 112, 113 & 116 themselves are good enough to ONLY fix the wrapping, but I faintly recall they were not.

As for line 114, I have stated in meganrogge's review that it's basically optional and can be removed.

I'll see what I can do within my lunch break, and thanks for the helper.

Tyriar

@meganrogge simplified it, basically handling the edge case where backtick is included specially instead of adding HTML support/complicated regexes. Could you check it out?

Tyriar · 2025-11-13T13:56:40Z

@Abrifq let me know if you're able to break this one, but I think it's solid

meganrogge

Works for me

Abrifq · 2025-11-14T07:52:28Z

@Abrifq let me know if you're able to break this one, but I think it's solid

Sorry, I just became available to check, I will update but this feels weird on UX.

src/vs/workbench/contrib/terminal/browser/terminalTooltip.ts

Abrifq · 2025-11-14T09:04:08Z

There is an even simpler version, I will make a new PR on top of this one.

@@ -109,15 +109,8 @@ export function refreshShellIntegrationInfoStatus(instance: ITerminalInstance) {
 	}
 	const combinedString = instance.capabilities.get(TerminalCapability.CommandDetection)?.promptInputModel.getCombinedString();
 	if (combinedString !== undefined) {
-		if (combinedString.includes('`')) {
-			detailedAdditions.push('Prompt input:' + [
-				'```',
-				combinedString, // No new lines so no need to escape ```
-				'```',
-			].map(e => `\n    ${e}`).join(''));
-		} else {
-			detailedAdditions.push(`Prompt input: \`${combinedString.replaceAll('`', '&#96;')}\``);
-		}
+		// Wrap with triple backticks so that single backticks can show up (command substitution in bash uses backticks, for example)
+		detailedAdditions.push(`Prompt input: \`\`\`${combinedString}\`\`\``);
 	}
 	const detailedAdditionsString = detailedAdditions.length > 0
 		? '\n\n' + detailedAdditions.map(e => `- ${e}`).join('\n')

Abrifq · 2025-11-14T09:10:01Z

#272425 (comment)
The simplest solution will be only wrapping with triple backticks and assume the user is not writing markdown in command line.

Using two backticks in a row is pretty much useless as it just makes an empty string.

Well, that's the simplest, the cleaner solution would be either adding some if not all css properties of <code> to <pre> or to tweak markdown string implementation (and usage) to append/add another instance of markdown string w/o changing the props of the parent one.

Tyriar · 2025-11-14T12:26:55Z

@Abrifq we definitely don't want to support HTML there. I also don't want to get into trying to change the markdown rendering. Again this is just debug info that's hidden by default, handling all edge cases perfectly isn't too important.

…t-input-visual-fix Cleanup #272425

vs-code-engineering bot assigned meganrogge Oct 21, 2025

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from 479b5dd to 6a9c04d Compare October 22, 2025 07:19

Abrifq commented Oct 22, 2025

View reviewed changes

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from 6a9c04d to 7b0877c Compare October 22, 2025 09:49

Abrifq marked this pull request as ready for review October 22, 2025 09:49

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from ab88aa6 to 5e797a9 Compare October 22, 2025 10:10

Abrifq changed the title ~~Replace Shell Integration's Prompt Input input's backtick wrapping with pre element~~ Replace Shell Integration's Prompt Input input's backtick wrapping with <code>wrapping</code> Oct 27, 2025

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from 5e797a9 to fc5842d Compare October 27, 2025 12:16

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from fc5842d to 3a92ee4 Compare October 28, 2025 05:23

This comment was marked as outdated.

Sign in to view

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from 3a92ee4 to 4e717e0 Compare October 28, 2025 05:47

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from 644016f to 3ccfea3 Compare October 28, 2025 08:01

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from 3ccfea3 to 9030ea6 Compare October 28, 2025 10:34

Abrifq and others added 4 commits October 28, 2025 13:35

Replace command prompt input "`" wrap with <code> wrap

ea4bbcf

Enable rendering HTML in terminal tooltip to fix command input wrapping

dcf03f0

Fix backticks not showing up in prompt input

9b8c336

Escape more markdown to keep prompt input as visually same as possible

d30c10e

Abrifq force-pushed the Abrifq/shell-integration-prompt-input-visual-fix branch from 9030ea6 to d30c10e Compare October 28, 2025 10:36

meganrogge removed their assignment Nov 12, 2025

meganrogge requested a review from Tyriar November 12, 2025 13:48

meganrogge reviewed Nov 12, 2025

View reviewed changes

src/vs/workbench/contrib/terminal/browser/terminalTooltip.ts Outdated Show resolved Hide resolved

vs-code-engineering bot assigned meganrogge Nov 12, 2025

Tyriar requested changes Nov 12, 2025

View reviewed changes

Use the escapeMarkdownSyntaxTokens helper

c566937

Tyriar self-assigned this Nov 13, 2025

Simplify solution

2a4a53b

Tyriar changed the title ~~Replace Shell Integration's Prompt Input input's backtick wrapping with <code>wrapping</code>~~ Fix terminal tab prompt input breaking when backticks are included Nov 13, 2025

Tyriar requested a review from meganrogge November 13, 2025 13:54

Tyriar added this to the November 2025 milestone Nov 13, 2025

Tyriar approved these changes Nov 13, 2025

View reviewed changes

Tyriar enabled auto-merge November 13, 2025 13:55

meganrogge approved these changes Nov 13, 2025

View reviewed changes

Tyriar merged commit 6f121ab into microsoft:main Nov 13, 2025
17 checks passed

Abrifq commented Nov 14, 2025

View reviewed changes

src/vs/workbench/contrib/terminal/browser/terminalTooltip.ts Show resolved Hide resolved

Abrifq mentioned this pull request Nov 14, 2025

Cleanup microsoft#272425 #277406

Merged

Tyriar added a commit that referenced this pull request Nov 14, 2025

Merge pull request #277406 from Abrifq/Abrifq/shell-integration-promp…

a95f3da

…t-input-visual-fix Cleanup #272425

vs-code-engineering bot locked and limited conversation to collaborators Dec 28, 2025

	private _doSync() {
	if (this._state !== PromptInputState.Input) {
	return;
	}

	let commandStartY = this._commandStartMarker?.line;
	if (commandStartY === undefined) {
	return;
	}

	const buffer = this._xterm.buffer.active;
	let line = buffer.getLine(commandStartY);
	const absoluteCursorY = buffer.baseY + buffer.cursorY;
	let cursorIndex: number \| undefined;

	let commandLine = line?.translateToString(true, this._commandStartX);
	if (this._shellType === PosixShellType.Fish && (!line \|\| !commandLine)) {
	commandStartY += 1;
	line = buffer.getLine(commandStartY);
	if (line) {
	commandLine = line.translateToString(true);
	cursorIndex = absoluteCursorY === commandStartY ? buffer.cursorX : commandLine?.trimEnd().length;
	}
	}
	if (line === undefined \|\| commandLine === undefined) {
	this._logService.trace(`PromptInputModel#_sync: no line`);
	return;
	}

	let value = commandLine;
	let ghostTextIndex = -1;
	if (cursorIndex === undefined) {
	if (absoluteCursorY === commandStartY) {
	cursorIndex = Math.min(this._getRelativeCursorIndex(this._commandStartX, buffer, line), commandLine.length);
	} else {
	cursorIndex = commandLine.trimEnd().length;
	}
	}

	// From command start line to cursor line
	for (let y = commandStartY + 1; y <= absoluteCursorY; y++) {
	const nextLine = buffer.getLine(y);
	const lineText = nextLine?.translateToString(true);
	if (lineText && nextLine) {
	// Check if the line wrapped without a new line (continuation) or
	// we're on the last line and the continuation prompt is not present, so we need to add the value
	if (nextLine.isWrapped \|\| (absoluteCursorY === y && this._continuationPrompt && !this._lineContainsContinuationPrompt(lineText))) {
	value += `${lineText}`;
	const relativeCursorIndex = this._getRelativeCursorIndex(0, buffer, nextLine);
	if (absoluteCursorY === y) {
	cursorIndex += relativeCursorIndex;
	} else {
	cursorIndex += lineText.length;
	}
	} else if (this._shellType === PosixShellType.Fish) {
	if (value.endsWith('\\')) {
	// Trim off the trailing backslash
	value = value.substring(0, value.length - 1);
	value += `${lineText.trim()}`;
	cursorIndex += lineText.trim().length - 1;
	} else {
	if (/^ {6,}/.test(lineText)) {
	// Was likely a new line
	value += `\n${lineText.trim()}`;
	cursorIndex += lineText.trim().length + 1;
	} else {
	value += lineText;
	cursorIndex += lineText.length;
	}
	}
	}
	// Verify continuation prompt if we have it, if this line doesn't have it then the
	// user likely just pressed enter.
	else if (this._continuationPrompt === undefined \|\| this._lineContainsContinuationPrompt(lineText)) {
	const trimmedLineText = this._trimContinuationPrompt(lineText);
	value += `\n${trimmedLineText}`;
	if (absoluteCursorY === y) {
	const continuationCellWidth = this._getContinuationPromptCellWidth(nextLine, lineText);
	const relativeCursorIndex = this._getRelativeCursorIndex(continuationCellWidth, buffer, nextLine);
	cursorIndex += relativeCursorIndex + 1;
	} else {
	cursorIndex += trimmedLineText.length + 1;
	}
	}
	}
	}

	// Below cursor line
	for (let y = absoluteCursorY + 1; y < buffer.baseY + this._xterm.rows; y++) {
	const belowCursorLine = buffer.getLine(y);
	const lineText = belowCursorLine?.translateToString(true);
	if (lineText && belowCursorLine) {
	if (this._shellType === PosixShellType.Fish) {
	value += `${lineText}`;
	} else if (this._continuationPrompt === undefined \|\| this._lineContainsContinuationPrompt(lineText)) {
	value += `\n${this._trimContinuationPrompt(lineText)}`;
	} else {
	value += lineText;
	}
	} else {
	break;
	}
	}

	if (this._logService.getLevel() === LogLevel.Trace) {
	this._logService.trace(`PromptInputModel#_sync: ${this.getCombinedString()}`);
	}

	// Adjust trailing whitespace
	{
	let trailingWhitespace = this._value.length - this._value.trimEnd().length;

	// Handle backspace key
	if (this._lastUserInput === '\x7F') {
	this._lastUserInput = '';
	if (cursorIndex === this._cursorIndex - 1) {
	// If trailing whitespace is being increased by removing a non-whitespace character
	if (this._value.trimEnd().length > value.trimEnd().length && value.trimEnd().length <= cursorIndex) {
	trailingWhitespace = Math.max((this._value.length - 1) - value.trimEnd().length, 0);
	}
	// Standard case; subtract from trailing whitespace
	else {
	trailingWhitespace = Math.max(trailingWhitespace - 1, 0);
	}

	}
	}

	// Handle delete key
	if (this._lastUserInput === '\x1b[3~') {
	this._lastUserInput = '';
	if (cursorIndex === this._cursorIndex) {
	trailingWhitespace = Math.max(trailingWhitespace - 1, 0);
	}
	}

	const valueLines = value.split('\n');
	const isMultiLine = valueLines.length > 1;
	const valueEndTrimmed = value.trimEnd();
	if (!isMultiLine) {
	// Adjust trimmed whitespace value based on cursor position
	if (valueEndTrimmed.length < value.length) {
	// Handle space key
	if (this._lastUserInput === ' ') {
	this._lastUserInput = '';
	if (cursorIndex > valueEndTrimmed.length && cursorIndex > this._cursorIndex) {
	trailingWhitespace++;
	}
	}
	trailingWhitespace = Math.max(cursorIndex - valueEndTrimmed.length, trailingWhitespace, 0);
	}

	// Handle case where a non-space character is inserted in the middle of trailing whitespace
	const charBeforeCursor = cursorIndex === 0 ? '' : value[cursorIndex - 1];
	if (trailingWhitespace > 0 && cursorIndex === this._cursorIndex + 1 && this._lastUserInput !== '' && charBeforeCursor !== ' ') {
	trailingWhitespace = this._value.length - this._cursorIndex;
	}
	}

	if (isMultiLine) {
	valueLines[valueLines.length - 1] = valueLines.at(-1)?.trimEnd() ?? '';
	const continuationOffset = (valueLines.length - 1) * (this._continuationPrompt?.length ?? 0);
	trailingWhitespace = Math.max(0, cursorIndex - value.length - continuationOffset);
	}

	value = valueLines.map(e => e.trimEnd()).join('\n') + ' '.repeat(trailingWhitespace);
	}

	ghostTextIndex = this._scanForGhostText(buffer, line, cursorIndex);

	if (this._value !== value \|\| this._cursorIndex !== cursorIndex \|\| this._ghostTextIndex !== ghostTextIndex) {
	this._value = value;
	this._cursorIndex = cursorIndex;
	this._ghostTextIndex = ghostTextIndex;
	this._onDidChangeInput.fire(this._createStateObject());
	}
	}

	export function escapeMarkdownSyntaxTokens(text: string): string {
	// escape markdown syntax tokens: http://daringfireball.net/projects/markdown/syntax#backslash
	return text.replace(/[\\`*_{}[\]()#+\-!~]/g, '\\$&'); // CodeQL [SM02383] Backslash is escaped in the character class
	}

Conversation

Abrifq commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abrifq left a comment

Choose a reason for hiding this comment

Uh oh!

Abrifq commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

meganrogge commented Oct 27, 2025

Uh oh!

This comment was marked as outdated.

Abrifq commented Oct 28, 2025

Update:

Uh oh!

Abrifq commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abrifq commented Oct 28, 2025

Main Branch (124710c)

My patch (3ccfea3)

Uh oh!

Abrifq commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abrifq commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abrifq commented Nov 12, 2025

Uh oh!

meganrogge Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Abrifq Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Tyriar Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Abrifq Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Tyriar Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Abrifq Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Tyriar left a comment

Choose a reason for hiding this comment

Uh oh!

Tyriar commented Nov 13, 2025

Uh oh!

meganrogge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Abrifq commented Nov 14, 2025

Uh oh!

Uh oh!

Abrifq commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Abrifq commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tyriar commented Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Abrifq commented Oct 21, 2025 •

edited

Loading

Abrifq commented Oct 22, 2025 •

edited

Loading

Abrifq commented Oct 28, 2025 •

edited

Loading

Main Branch (`124710c`)

My patch (`3ccfea3`)

Abrifq commented Oct 28, 2025 •

edited

Loading

Abrifq commented Nov 3, 2025 •

edited

Loading

Abrifq commented Nov 14, 2025 •

edited

Loading

Abrifq commented Nov 14, 2025 •

edited

Loading