Make pair colorizer ignore \@ifnextchar#272329
Merged
hediet merged 2 commits intomicrosoft:mainfrom Oct 21, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where the bracket pair colorizer incorrectly processes \@ifnextchar commands in LaTeX syntax. The fix adds a specific pattern to identify and mark \@ifnextchar{, \@ifnextchar(, and \@ifnextchar[ as special control keywords, then configures them as unbalanced bracket scopes to prevent the bracket pair colorizer from being misled.
Key Changes:
- Added a new syntax pattern to recognize
\@ifnextcharfollowed by opening brackets - Configured the new pattern as an unbalanced bracket scope in the LaTeX grammar configuration
- Updated version references to reflect the upstream commit containing this fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| extensions/latex/syntaxes/TeX.tmLanguage.json | Added ifnextchar pattern definition and inclusion to recognize \@ifnextchar commands with brackets |
| extensions/latex/package.json | Registered the ifnextchar scope as an unbalanced bracket scope to exclude it from pair colorization |
| extensions/latex/cgmanifest.json | Updated commit hash reference to track the upstream fix |
Co-authored-by: Copilot <[email protected]>
jlelong
force-pushed
the
latex_ifnextchar
branch
from
6952952 to
0e96172
Compare
hediet
approved these changes
Oct 21, 2025
lszomoru
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes jlelong/vscode-latex-basics#123. It prevents the bracket pair colorizer to be misled by
\@ifnextchar{,\@ifnextchar(and\@ifnextchar[.