fix: memory leak in getTerminalActionBarArgs#269516
Merged
meganrogge merged 4 commits intomicrosoft:mainfrom Oct 8, 2025
Merged
fix: memory leak in getTerminalActionBarArgs#269516meganrogge merged 4 commits intomicrosoft:mainfrom
meganrogge merged 4 commits intomicrosoft:mainfrom
Conversation
Collaborator
|
cc @Tyriar |
alexr00
approved these changes
Oct 2, 2025
Tyriar
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a memory leak in
getTerminalActionBarArgsby disposing the previous actions when updating the actions.Before
When opening and closing the panel, many instances of
getTerminalActionBarArgsare created:After
When opening and closing the panel, the number of

getTerminalActionBarArgsfunctions stays constant:Only a leaking
ifunction or class is remaining, which seems to be related to xterm addon WebGL.{ "namedFunctionCount3": [ { "count": 2473, "delta": 2377, "name": "i", "sourceLocation": "vscode-file://vscode-app/home/simon/.cache/repos/vscode/node_modules/@xterm/addon-webgl/lib/addon-webgl.js:0:82918", "originalName": null } ], "isLeak": true }