mcp: update with icons added to resource templates #269199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds icon support to MCP (Model Context Protocol) resource templates, following up on a previous change. The update ensures that resource templates can display icons consistently with resources.
- Extends the
ResourceTemplateinterface to include icon support through theIconsinterface - Updates resource template construction to parse and pass icon data
- Refactors icon handling to use a new
fromParsedmethod for better separation of concerns
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/mcp/common/modelContextProtocol.ts | Extends ResourceTemplate interface to include Icons |
| src/vs/workbench/contrib/mcp/common/mcpTypes.ts | Adds icons property to IMcpResourceTemplate interface |
| src/vs/workbench/contrib/mcp/common/mcpServer.ts | Updates resource template construction to include parsed icons |
| src/vs/workbench/contrib/mcp/common/mcpIcons.ts | Adds ParsedMcpIcons type and fromParsed method for better icon handling |
| src/vs/workbench/contrib/mcp/browser/mcpResourceQuickAccess.ts | Consolidates icon handling logic for both resources and templates |
dmitrivMS
approved these changes
Sep 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup addition from modelcontextprotocol/modelcontextprotocol#1565