Skip to content

Conversation

@CGNonofr
Copy link
Contributor

fix #259835

It looks like the solution was quite simple at the end @bpasero

Tested with firefox 143

CGNonofr pushed a commit to CodinGame/monaco-vscode-api that referenced this pull request Sep 30, 2025
@bpasero
Copy link
Member

bpasero commented Sep 30, 2025

@CGNonofr very nice (have to confirm it works), can we make this change with isFirefox only?

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Oct 1, 2025

@CGNonofr very nice (have to confirm it works), can we make this change with isFirefox only?

I have the feeling that characterData is the mutation we are looking for, and that childList is the one webkit-specific 🤔 What do you think?

@bpasero
Copy link
Member

bpasero commented Oct 1, 2025

@CGNonofr I actually tested this with a full insiders build and it turns out I only get it to work with both of them. Can you change it to this:

subtree: isFirefox, characterData: isFirefox

And update the PR?

@bpasero bpasero added this to the September 2025 milestone Oct 1, 2025
@CGNonofr CGNonofr force-pushed the fix-global-stylesheet-application branch from 3405e0e to 3cae081 Compare October 1, 2025 12:09
@CGNonofr
Copy link
Contributor Author

CGNonofr commented Oct 1, 2025

@CGNonofr I actually tested this with a full insiders build and it turns out I only get it to work with both of them. Can you change it to this:

subtree: isFirefox, characterData: isFirefox

And update the PR?

I'm not sure why you consider having characterData and subtree enabled outside of firefox harmful, I would even say that it's probably more futur-proof 🤷 but I've amended the commit

Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@bpasero bpasero enabled auto-merge (squash) October 1, 2025 12:15
@bpasero
Copy link
Member

bpasero commented Oct 1, 2025

I'm not sure why you consider having characterData and subtree enabled outside of firefox harmful, I would even say that it's probably more futur-proof 🤷 but I've amended the commit

That is fair, but I feel uneasy doing a change without fully understanding what it fixes for the other browsers. It seems that all other browsers are doing fine so far, ever since we shipped floating windows.

@bpasero bpasero merged commit fc9b022 into microsoft:main Oct 1, 2025
17 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firefox: changes to global stylesheets are not applied live

3 participants