mcp: support custom icons for servers, tools, resources #268889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom icons in MCP (Model Context Protocol) servers, tools, and resources. The changes implement the icon specification from the MCP protocol, allowing servers to provide custom icons that are displayed in the VS Code UI.
Key Changes
- Adds icon parsing and validation logic with security constraints based on transport type
- Updates MCP data models to include icon support for servers, tools, and resources
- Integrates custom icons into the UI for tool picker, resource quick access, and language model tools
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/mcp/common/mcpIcons.ts |
New module implementing icon parsing, validation, and caching logic |
src/vs/workbench/contrib/mcp/test/common/mcpIcons.test.ts |
Comprehensive test suite for icon validation and parsing functionality |
src/vs/workbench/contrib/mcp/common/mcpTypes.ts |
Updates type definitions to include IMcpIcons interface and icon properties |
src/vs/workbench/contrib/mcp/common/mcpServer.ts |
Integrates icon parsing into server metadata, tools, prompts, and resources |
src/vs/workbench/contrib/mcp/common/mcpLanguageModelToolContribution.ts |
Updates tool UI to display custom icons when available |
src/vs/workbench/contrib/mcp/browser/mcpResourceQuickAccess.ts |
Adds icon support to resource quick access picker |
src/vs/workbench/contrib/chat/browser/actions/chatToolPicker.ts |
Updates chat tool picker to show server custom icons |
dmitrivMS
approved these changes
Sep 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopts modelcontextprotocol/modelcontextprotocol#955
Closes #265892