mcp: allow connecting to servers on unix socket/windows pipes #268524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for connecting to MCP (Model Context Protocol) servers via Unix sockets and Windows named pipes, expanding beyond the existing stdio and HTTP transport methods. The implementation utilizes the undici library to handle custom socket connections while maintaining compatibility with the existing HTTP transport layer.
Key Changes:
- Extends the HTTP transport handler to support Unix sockets and Windows pipes using URI schemes (
unix://andpipe://) - Refactors the MCP HTTP handling to allow Node.js-specific implementations with undici
- Adds undici as an explicit dependency for advanced HTTP client features
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vs/workbench/api/node/extHostMcpNode.ts | Implements Node.js-specific MCP HTTP handler with Unix socket/pipe support using undici |
| src/vs/workbench/api/common/extHostMcp.ts | Refactors base HTTP handler to support extensible fetch implementation and exports necessary types |
| package.json | Adds undici dependency for advanced HTTP client functionality |
| eslint.config.js | Updates ESLint configuration to allow undici imports |
bwateratmsft
approved these changes
Sep 26, 2025
roblourens
approved these changes
Sep 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#268488 from me since it touches package.json. Note that
undiciwas already a transitive dependency we had in the extension host, so there is no bundle size change from the dependency.