Don't use unbound this for dispose
#268202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For microsoft#267785 This pattern is not safe when working with an `IDisposable`
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a potential issue with unbound method references when disposing of chat agents. The change ensures proper context binding when calling the dispose method on disposable objects.
- Wraps the dispose method call in an arrow function to maintain proper
thiscontext
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
connor4312
approved these changes
Sep 24, 2025
mjbvz
changed the title
this for dispose
mjbvz
added a commit
to mjbvz/vscode
that referenced
this pull request
Sep 24, 2025
Found while fixing microsoft#268202 Will see if we want to add an eslint rule for this too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #267785
This pattern is not safe when working with an
IDisposable