Copy selection for deleted chunk in inline diff#267991
Copy selection for deleted chunk in inline diff#267991hediet merged 6 commits intomicrosoft:mainfrom
Conversation
(Attempt to) Fix microsoft#8226
|
Hey! Thanks for the PR ;) I tried it, but the selection is not rendered for me (Windows):
Can you look into this? Thanks! |
|
Thanks for the quick response! Could you try if my last commit help with that? This was actually my original version but then I made the CSS class "dynamic" to avoid things like this: But that likely has created some race condition :( In hindsight, this is probably still better than not showing the selection sometimes... but let me know if you want the above situation ⬆️ fixed as well. I can play with it a bit more. Edit: perhaps some hover / mousein&out event could be better suited to toggle that CSS class? Let me know what you think :) |
There was a problem hiding this comment.
Thanks for the PR!
I'm not sure that we should show the context menu automatically, but its still better than before, so I'm happy to get this change in.
Also I think it would be great if if could copy the text of multiple deleted chunks at once, ideally including the unchanged lines in between.
| .monaco-editor .line-delete-selectable { | ||
| user-select: text !important; | ||
| -webkit-user-select: text !important; | ||
| z-index: 1 !important; | ||
| } | ||
|
|
||
| .line-delete-selectable .view-line { | ||
| user-select: text !important; | ||
| -webkit-user-select: text !important; | ||
| } |
There was a problem hiding this comment.
@hediet might want to follow up with consistent selector prefix and/or nesting?
3 participants
An attempt to fix #8226
Hi @hediet , can I interest you with (yet another) PR for #8226, a.k.a. inline diff deleted chunk copy selection? :)
The main idea is to calculate the exact line and column for the start & end of the selection in a view zone, and extract the corresponding code chunk using the text model API.
Demo:
This works with both the menu item, and the browser 'copy' event (Ctrl/Cmd+C).
I have put the setup in a reusable method in a separate file, following the example of renderLines.ts
Due to the view zone, there are some hackery involved to get those line and column numbers right (the line number extraction is the same as that from the inlineDiffDeletedCodeMargin.ts). Let me know if you see any issues, or if you prefer to solve it in a different way.
Thanks!