Do not allow localhost redirect in favor of loopback IP redirect #267546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes localhost redirect URLs from OAuth configuration in favor of loopback IP (127.0.0.1) redirect URLs only. This change improves security by preventing potential localhost-based attacks while maintaining the same functionality through the more secure loopback IP addresses.
Key Changes
- Removes
http://localhost/andhttp://localhost:${DEFAULT_AUTH_FLOW_PORT}/from OAuth redirect URI configurations - Retains
http://127.0.0.1/andhttp://127.0.0.1:${DEFAULT_AUTH_FLOW_PORT}/for local development authentication flows - Updates corresponding test assertions to match the new configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/base/common/oauth.ts | Removes localhost redirect URIs from dynamic registration, keeping only loopback IP addresses |
| src/vs/base/test/common/oauth.test.ts | Updates test expectations to match the removal of localhost redirect URIs |
Contributor
Author
|
Addresses #267545 |
Contributor
Author
@microsoft-github-policy-service agree |
TylerLeonhardt
approved these changes
Sep 22, 2025
Member
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
LGTM. We only use 127.0.0.1 when we spin up the local server so this makes sense.
roblourens
approved these changes
Sep 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267545