-
Notifications
You must be signed in to change notification settings - Fork 37.4k
fix: confirmation btn style #267438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: confirmation btn style #267438
Conversation
@microsoft-github-policy-service agree |
|
Hai, @roblourens , I have submitted a Merge Request regarding an issue where this button is displayed abnormally. Although the fix is simple, the impact is significant. I hope you can review it, or consider resolving this problem in the next release. Thank you! |
| - Write concise, actionable instructions (~20-50 lines) using markdown structure | ||
| - Include specific examples from the codebase when describing patterns | ||
| - Avoid generic advice ("write tests", "handle errors") - focus on THIS project's specific approaches | ||
| - Avoid generic advice ("write tests", "handle errors") - focus on this project's specific approaches |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a problem? It's emphasizing this. Seems ok to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tyriar Fine,Just a grammar, I have revert it! please review agent, Thinks
Revert this to THIS
|
@Tyriar The release version of VSCode did not catch up with this time, and this bug is also a display anomaly for Korean which btn text is 허용. Therefore, the impact of this bug is quite significant, Being able to be resolved early is a beautiful thing |
Tyriar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This MR addresses two UI-related issues in VS Code:
Issue 1: Inconsistent Text Casing in Generate Instructions Prompt
Problem: In the generate instructions prompt text, "THIS" appears in that
Solution: Change "THIS" to lowercase "this"
Issue 2: Layout Issues in Copilot Tool Consent Dialog
Problem: The "Continue" button in Copilot's tool consent dialog has layout issues:
In Chinese language settings, the button text wraps unexpectedly, breaking the intended layout
When the dialog content is lengthy, the button styling doesn't match the expected design
The button layout is not responsive to different content lengths and languages
Before:


After
After:


