Add conversation id to mcp meta #265303
Merged
Add conversation id to mcp meta #265303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
requested changes
Sep 8, 2025
Comment on lines
913
to
916
| const meta: Record<string, unknown> = { | ||
| 'vscode.client': 'vscode', | ||
| 'vscode.progressToken': progressToken | ||
| }; |
Member
There was a problem hiding this comment.
The client and progress token are already sent in the protocol, we should not send them separately here
Comment on lines
865
to
867
| const meta: Record<string, unknown> = { | ||
| 'vscode.client': 'vscode' | ||
| }; |
Member
There was a problem hiding this comment.
Similarly, we no need to send the client here
connor4312
approved these changes
Sep 11, 2025
Tyriar
approved these changes
Sep 11, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #265302