fix: memory leak in chat widget #265002
Merged
fix: memory leak in chat widget #265002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@justschen not sure if this is you? |
bpasero
approved these changes
Sep 22, 2025
lszomoru
approved these changes
Sep 22, 2025
Collaborator
|
git blame says tyler, but this is a good change regardless! thanks @SimonSiefke |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (Opening and Closing Chat Widget 197 times):
It seems that each time opening the chat widget, a new timeout disposable is registered, which seems to make the number of disposables grow by one each time.
The change uses a MutableDisposable to clear the previous timeout disposable when the setVisible function is called.