fix: confirm response based on promise #263894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
reviewed
Aug 28, 2025
src/vs/workbench/contrib/chat/common/chatProgressTypes/chatToolInvocation.ts
Outdated
Show resolved
Hide resolved
connor4312
approved these changes
Aug 28, 2025
DonJayamanne
approved these changes
Aug 28, 2025
DonJayamanne
approved these changes
Aug 28, 2025
karthiknadig
approved these changes
Aug 28, 2025
zhichli
approved these changes
Aug 28, 2025
When using the new `workbench.action.chat.open.blockOnResponse`
feature, if the VSC instance was in auto-approve mode, it was observed
that the command was resolving before the tool finished invocation.
This resulted in a race betwee sync and async code:
```
if (!this._confirmationMessages) {
// No confirmation needed
this._isConfirmed = { type: ToolConfirmKind.ConfirmationNotNeeded };
this._confirmDeferred.complete(this._isConfirmed);
}
```
and then the check for confirmation in `isConfirmed`.
karthiknadig
force-pushed
the
fix-block-on-response
branch
from
5290378 to
150cbd4
Compare
rwoll
added a commit
to rwoll/vscode
that referenced
this pull request
Aug 29, 2025
This reverts commit 6f24cee. It broke tool calling: microsoft#264023. I also need to re-asses how I missed this during testing.
TylerLeonhardt
pushed a commit
that referenced
this pull request
Aug 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new
workbench.action.chat.open.blockOnResponsefeature, if the VSC instance was in auto-approve mode, it was observed that the command was resolving before the tool finished invocation.This resulted in a race betwee sync and async code.