Fix disposable leak in BrowserSocketFactory #263736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[LEAKED DISPOSABLE] Error: CREATED via: at GCBasedDisposableTracker.trackDisposable src/vs/base/common/lifecycle.ts:47:23 at trackDisposable src/vs/base/common/lifecycle.ts:218:24 at toDisposable src/vs/base/common/lifecycle.ts:296:18 at BrowserWebSocket._event [as onOpen] src/vs/base/common/event.ts:879:28 at new Promise (<anonymous>) at BrowserSocketFactory.connect src/vs/platform/remote/browser/browserSocketFactory.ts:194:16 at RemoteSocketFactoryService.connect src/vs/platform/remote/common/remoteSocketFactoryService.ts:31:30 at createSocket src/vs/platform/remote/common/remoteAgentConnection.ts:122:32 at connectToRemoteExtensionHostAgent src/vs/platform/remote/common/remoteAgentConnection.ts:159:24 at connectToRemoteExtensionHostAgentAndReadOneMessage src/vs/platform/remote/common/remoteAgentConnection.ts:232:46 at doConnectRemoteAgentExtensionHost src/vs/platform/remote/common/remoteAgentConnection.ts:258:46 at ExtensionHostPersistentConnection._reconnect src/vs/platform/remote/common/remoteAgentConnection.ts:622:15 at ExtensionHostPersistentConnection._runReconnectingLoop src/vs/platform/remote/common/remoteAgentConnection.ts:515:28 at async ExtensionHostPersistentConnection._beginReconnecting src/vs/platform/remote/common/remoteAgentConnection.ts:470:13
bpasero
approved these changes
Sep 22, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a disposable leak in the BrowserSocketFactory where event listeners were not being properly cleaned up. The fix ensures that both the error listener and open listener are properly disposed when the socket connection is established.
- Replaces manual disposable management with a DisposableStore to track multiple listeners
- Ensures both onError and onOpen listeners are properly cleaned up when the connection succeeds
dbaeumer
approved these changes
Sep 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[LEAKED DISPOSABLE] Error: CREATED via:
at GCBasedDisposableTracker.trackDisposable src/vs/base/common/lifecycle.ts:47:23
at trackDisposable src/vs/base/common/lifecycle.ts:218:24
at toDisposable src/vs/base/common/lifecycle.ts:296:18
at BrowserWebSocket._event [as onOpen] src/vs/base/common/event.ts:879:28
at new Promise ()
at BrowserSocketFactory.connect src/vs/platform/remote/browser/browserSocketFactory.ts:194:16
at RemoteSocketFactoryService.connect src/vs/platform/remote/common/remoteSocketFactoryService.ts:31:30
at createSocket src/vs/platform/remote/common/remoteAgentConnection.ts:122:32
at connectToRemoteExtensionHostAgent src/vs/platform/remote/common/remoteAgentConnection.ts:159:24
at connectToRemoteExtensionHostAgentAndReadOneMessage src/vs/platform/remote/common/remoteAgentConnection.ts:232:46
at doConnectRemoteAgentExtensionHost src/vs/platform/remote/common/remoteAgentConnection.ts:258:46
at ExtensionHostPersistentConnection._reconnect src/vs/platform/remote/common/remoteAgentConnection.ts:622:15
at ExtensionHostPersistentConnection._runReconnectingLoop src/vs/platform/remote/common/remoteAgentConnection.ts:515:28
at async ExtensionHostPersistentConnection._beginReconnecting src/vs/platform/remote/common/remoteAgentConnection.ts:470:13