fix: parse commands in chat.open commands #263458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`workbench.action.chat.open` did not always trigger a parse of the input resulting in `/<prompt>` not being recognized as a prompt command. If `isPartialQuery: false` (default), then the commanded used [`acceptInput` intead of `setInput`](https://github.com/microsoft/vscode/blob/709b8fabf55c505cbe5603ce654ecf3a8766a7a6/src/vs/workbench/contrib/chat/browser/actions/chatActions.ts#L244) only the latter of which will trigger a [re-parse of the query](https://github.com/microsoft/vscode/blob/709b8fabf55c505cbe5603ce654ecf3a8766a7a6/src/vs/workbench/contrib/chat/browser/chatWidget.ts#L1640) to critcially turn [`/<prompt>` into a `ChatRequestSlashPromptPart`](https://github.com/microsoft/vscode/blob/d2ff8d16065d4748b8a205bfebdc98d7d76f7864/src/vs/workbench/contrib/chat/common/chatRequestParser.ts#L231). **Reviewers**: There's a few places `acceptInput` is called with a query in the codebase. It's not clear to me if the others have the same issue or if always triggering a re-parse would double parse.
rwoll
commented
Aug 26, 2025
roblourens
approved these changes
Aug 26, 2025
benibenj
approved these changes
Aug 26, 2025
osortega
pushed a commit
that referenced
this pull request
Aug 26, 2025
`workbench.action.chat.open` did not always trigger a parse of the input resulting in `/<prompt>` not being recognized as a prompt command. If `isPartialQuery: false` (default), then the commanded used [`acceptInput` intead of `setInput`](https://github.com/microsoft/vscode/blob/709b8fabf55c505cbe5603ce654ecf3a8766a7a6/src/vs/workbench/contrib/chat/browser/actions/chatActions.ts#L244) only the latter of which will trigger a [re-parse of the query](https://github.com/microsoft/vscode/blob/709b8fabf55c505cbe5603ce654ecf3a8766a7a6/src/vs/workbench/contrib/chat/browser/chatWidget.ts#L1640) to critcially turn [`/<prompt>` into a `ChatRequestSlashPromptPart`](https://github.com/microsoft/vscode/blob/d2ff8d16065d4748b8a205bfebdc98d7d76f7864/src/vs/workbench/contrib/chat/common/chatRequestParser.ts#L231). **Reviewers**: There's a few places `acceptInput` is called with a query in the codebase. It's not clear to me if the others have the same issue or if always triggering a re-parse would double parse.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workbench.action.chat.opendid not always trigger a parse of the input resulting in/<prompt>not being recognized as a prompt command when it's expected to.If
isPartialQuery: false(default), then the command usedacceptInputintead ofsetInputonly the latter of which will trigger a re-parse of the query to critcially turn/<prompt>into aChatRequestSlashPromptPart.Reviewers: There's a few places
acceptInputis called with a query in the codebase. It's not clear to me if the others have the same issue or if always triggering a re-parse would double parse.