tools: implement 'skip' for tool calls in place of cancel #263314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
approved these changes
Aug 25, 2025
osortega
pushed a commit
that referenced
this pull request
Aug 26, 2025
rwoll
added a commit
to rwoll/vscode
that referenced
this pull request
Aug 29, 2025
* `getIcon` did not account for `ToolConfirmKind.Setting` (e.g. auto-approve) * `completion` promise was being changed to `Canceled` despite it already being resolved. See my [verbose(!) debugging comment](microsoft#264023 (comment)) which walks you through states of `ConfirmationKind` in `getIcon` under different commits. Fixes microsoft#264023. Relates microsoft#263314 (`getIcon` added by @connor4312). Relates microsoft#262982 (`ConfirmationKind.UserSetting` added by @Tyriar). Reviewers: I'm not 100% on what the expected UI iconography experience is, so please verify that the icons align with what y'all have in mind. Suggested follow ups: - [ ] Tests - especially one around `getIcon` to ensure it handles `ConfirmationKind` exhaustively as folks add new kinds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259534