Skip to content

debug: convert the renderer attacher to a standard websocket#262546

Merged
connor4312 merged 1 commit intomainfrom
connor4312/cdp-renderer-ws
Aug 20, 2025
Merged

debug: convert the renderer attacher to a standard websocket#262546
connor4312 merged 1 commit intomainfrom
connor4312/cdp-renderer-ws

Conversation

@connor4312
Copy link
Member

Allows better interoperability with other tools. rendererDebugPort
is not rendererDebugAddr which is a ws:// address.

Allows better interoperability with other tools. `rendererDebugPort`
is not `rendererDebugAddr` which is a `ws://` address.
@connor4312 connor4312 enabled auto-merge (squash) August 20, 2025 18:41
@connor4312 connor4312 self-assigned this Aug 20, 2025
@vs-code-engineering vs-code-engineering bot added this to the August 2025 milestone Aug 20, 2025
connor4312 added a commit to microsoft/vscode-js-debug that referenced this pull request Aug 20, 2025
@connor4312 connor4312 merged commit 5b009d5 into main Aug 20, 2025
18 checks passed
@connor4312 connor4312 deleted the connor4312/cdp-renderer-ws branch August 20, 2025 19:34
connor4312 added a commit to microsoft/vscode-js-debug that referenced this pull request Aug 20, 2025
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

import * as crypto from 'crypto';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connor4312 you import crypto twice

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants