Skip to content

support model switching in automation #262420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rzhao271 merged 8 commits into from
Aug 20, 2025
Merged

support model switching in automation #262420

rzhao271 merged 8 commits into from
Aug 20, 2025

Conversation

@rwoll
Copy link
Member

@rwoll rwoll commented Aug 20, 2025 •
edited
Loading

Programmatically allow setting models via workbench.action.chat.open for automation scenarios.

setCurrentLanguageModel implementation visibility is changed from private to public, but it's implementation remains unchanged. Re-located to be alongside the other public methods.

Manually tested the command:

Screenshot 2025-08-20 at 10 13 56 AM

@rwoll rwoll marked this pull request as ready for review August 20, 2025 02:21
@rwoll
Copy link
Member Author

rwoll commented Aug 20, 2025

/cc @karthiknadig @connor4312 @roblourens for review

@roblourens roblourens requested a review from lramos15 August 20, 2025 04:22
roblourens
roblourens previously approved these changes Aug 20, 2025
View reviewed changes
@vs-code-engineering vs-code-engineering bot added this to the August 2025 milestone Aug 20, 2025
connor4312
connor4312 previously approved these changes Aug 20, 2025
View reviewed changes
@connor4312 connor4312 enabled auto-merge (squash) August 20, 2025 17:15
auto-merge was automatically disabled August 20, 2025 17:16

Head branch was pushed to by a user without write access

@rwoll rwoll requested review from connor4312 and roblourens August 20, 2025 17:16
@connor4312 connor4312 enabled auto-merge (squash) August 20, 2025 17:18
connor4312
connor4312 previously approved these changes Aug 20, 2025
View reviewed changes
mjbvz
mjbvz previously approved these changes Aug 20, 2025
View reviewed changes
@rwoll rwoll requested review from connor4312 and mjbvz August 20, 2025 17:40
@rwoll rwoll marked this pull request as draft August 20, 2025 17:43
auto-merge was automatically disabled August 20, 2025 17:43

Pull request was converted to draft

@rwoll rwoll dismissed stale reviews from mjbvz and connor4312 via 900b8b3 August 20, 2025 17:44
@rwoll
Copy link
Member Author

rwoll commented Aug 20, 2025

Converting to draft while I sort out a hygiene error:

[10:42:43] /Users/rosswollman/code/vsc/vscode/src/vs/workbench/contrib/chat/browser/actions/chatActions.ts: line 77, col 43, Warning - Imports violates 'vs/base/{common,browser}/** or vs/base/parts/*/{common,browser}/** or vs/platform/*/{common,browser}/** or vs/editor/{common,browser}/** or vs/editor/contrib/*/{common,browser}/** or vs/workbench/{common,browser}/** or vs/workbench/services/*/{common,browser}/** or vs/workbench/contrib/*/{common,browser}/** or vs/workbench/contrib/terminal/terminalContribChatExports* or vs/workbench/contrib/terminal/terminalContribExports* or vscode-notebook-renderer or @vscode/tree-sitter-wasm or @xterm/xterm or @xterm/addon-* or vscode-textmate or vs/nls.js or vs/amdX.js' restrictions. See https://github.com/microsoft/vscode/wiki/Source-Code-Organization (local/code-import-patterns)

@rwoll rwoll marked this pull request as ready for review August 20, 2025 17:48
connor4312
connor4312 previously approved these changes Aug 20, 2025
View reviewed changes
@connor4312 connor4312 enabled auto-merge (squash) August 20, 2025 17:50
rzhao271
rzhao271 previously approved these changes Aug 20, 2025
View reviewed changes
auto-merge was automatically disabled August 20, 2025 17:57

Head branch was pushed to by a user without write access

@rwoll rwoll dismissed stale reviews from rzhao271 and connor4312 via cd98f34 August 20, 2025 17:57
@rwoll rwoll requested review from connor4312 and rzhao271 August 20, 2025 18:04
@rzhao271 rzhao271 merged commit 5a7aa18 into microsoft:main Aug 20, 2025
17 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@connor4312 connor4312 connor4312 approved these changes

@rzhao271 rzhao271 rzhao271 approved these changes

@lramos15 lramos15 Awaiting requested review from lramos15

@roblourens roblourens Awaiting requested review from roblourens

@mjbvz mjbvz Awaiting requested review from mjbvz

Assignees

@aeschli aeschli

Labels

triage-needed

Projects

None yet

Milestone

August 2025

Development

Successfully merging this pull request may close these issues.

6 participants

@rwoll @roblourens @connor4312 @rzhao271 @mjbvz @aeschli