terminalProcessManager: fix disposable leak #261710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[LEAKED DISPOSABLE] Error: CREATED via: at GCBasedDisposableTracker.trackDisposable src/vs/base/common/lifecycle.ts:47:23 at trackDisposable src/vs/base/common/lifecycle.ts:218:24 at toDisposable src/vs/base/common/lifecycle.ts:296:18 at LocalPty._event [as onRestoreCommands] src/vs/base/common/event.ts:879:28 at TerminalProcessManager.createProcess src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts:340:52 at async TerminalInstance._createProcess src/vs/workbench/contrib/terminal/browser/terminalInstance.ts:1973:9
|
test |
Contributor
|
Thanks for working on this. Were there steps you took to reproduce the issue? @tmm1 |
meganrogge
approved these changes
Aug 15, 2025
Contributor
Author
|
I don't have a clear repro but I noticed this happening on some macs after |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[LEAKED DISPOSABLE] Error: CREATED via:
at GCBasedDisposableTracker.trackDisposable src/vs/base/common/lifecycle.ts:47:23
at trackDisposable src/vs/base/common/lifecycle.ts:218:24
at toDisposable src/vs/base/common/lifecycle.ts:296:18
at LocalPty._event [as onRestoreCommands] src/vs/base/common/event.ts:879:28
at TerminalProcessManager.createProcess src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts:340:52
at async TerminalInstance._createProcess src/vs/workbench/contrib/terminal/browser/terminalInstance.ts:1973:9