Add support for a help link when MCP assisted installation fails #260215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
reviewed
Aug 7, 2025
src/vs/workbench/contrib/mcp/browser/mcpCommandsAddConfiguration.ts
Outdated
Show resolved
Hide resolved
connor4312
approved these changes
Aug 7, 2025
Tyriar
approved these changes
Aug 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of #257679.
This will also support #259901 if, for example, we move to using
npmfor the "does the package exist" check and npm is not available.I am working in using the server.json contained in NuGet packages to improve MCP installation. To do these, I need to invoke
dotnet tool installcommands to download the package. If the user does not havedotnetinstalled, we should let them known. This is prior to the MCP server being installed so the existing notification flow will not kick in yet.The URL and label are optionally sent back as part of the error. I believe this is a useful additional to the contract of
github.copilot.chat.mcp.setup.validatePackage.It looks like this:
Also, added
dotnetto the list of recognized missing commands in casedotnet tool execis used.Also, fix a misnamed editor service dependency.