Hey, just a quick note: this implementation appears to be identical to the original version of my PR #259352 before changes were requested. I would appreciate attribution or at least a mention that the original work came from there.

@JBlitzar the change is a revert of f8f0c0e, what am I missing?

Would be nice to be acknowledged for the work done in #259352 is all

@JBlitzar that PR was not merged. Again what am I missing? You can have credits for bringing up the idea of restoring the original code, but we typically do not call that out in our release notes.

Ok then. Just so we're on the same page, here's my current understanding of the situation:

I suggested something with open -a (v1)
I learned about the singleton instance argument passing etc, and made a solution (v2)
Deepak suggested hiding first and showing if it's the only instance (v3)

You merge what essentially was v2 except independently made previously. (v0)

Since I didn't write v0, I shouldn't be credited. At the same time, I wrote v2 (which seems to be the same except for maybe line ordering and comment wording) independently, but that didn't get merged. I obviously brought up the conversation, but that isn't credited.

So this all makes logical sense. Still, from my perspective it feels like I wrote a solution, revised on feedback, and then the same thing was self merged by a maintainer without credit. For me, the main incentive of contributing to OSS is crediting, so it felt kind of discouraging, even if technically fine

@JBlitzar no worries, I can add your original PR to our "Thank you" section of the upcoming release notes, which is normally automatically generated for each accepted PR, pretending as if your PR was accepted. How does that sound?

For the inconvenience, I enabled your GH handle to receive some swag from us, if you log in at: https://app.brilliantmade.com/receive/VS%20Code/microatckbfdy

Now I am looking forward to more PRs from you though 👍

Wow, amazing! Thanks so much, I really appreciate it.

As this very likely is the cause of #274146, I am going to revert.