Skip to content

Conversation

@JBlitzar
Copy link

@JBlitzar JBlitzar commented Aug 2, 2025

As discussed in #258824 (comment)

(and previously #131213 (comment))

Calls app.dock.hide() after another running instance is detected.

@deepak1556

@deepak1556
Copy link
Collaborator

Calling hide at this point might be late we could have a flash of the dock icon. Can we try to start the application with dock hidden and if instance can be claimed then call dock.show ?

@bpasero
Copy link
Member

bpasero commented Aug 4, 2025

I like the idea of trying this again, but shouldn't we just restore how it used to be before we removed it? I think I was calling it at a very early point.

@bpasero
Copy link
Member

bpasero commented Aug 5, 2025

Thanks, but I do not feel good restoring anything but the solution we had in place before we reverted it: f8f0c0e

Specifically I think optimistically hiding the dock right on startup could lead to unexpected issues, unless macOS guidelines tell us that this is the official way of doing it.

This might still bring back the issue of multiple dock icons and in that case we will have to revert again, but lets test this in insiders.

Continues in #259883

@bpasero bpasero closed this Aug 5, 2025
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants