fix: memory leak in extension features tab #256887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandy081
approved these changes
Jul 22, 2025
deepak1556
approved these changes
Jul 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an event listener leak in the extensions editor features tab.
Event listeners (before)
One end-to-end test showed an
auxclickandkeydownevent listener leak frommarkdownRenderer.ts.{ "eventListenersWithStackTrace": [ { "type": "auxclick", "description": "n=>this.a.fire(n)", "objectId": "-6737128020740298089.4.35825", "stack": [ "listener (file:///workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:69:53100)", "Object.onWillAddFirstListener (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:70:53162)", "u (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:29:1565)", "vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:27:6613", "Array.map (<anonymous>)", "vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:27:6605", "b0 (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:384:2706)", "Yxe.r (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2126:72)", "Yxe.n (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2111:336)" ], "count": 194, "originalStack": [ "file:/Users/cloudtest/vss/_work/1/s/src/vs/base/browser/event.ts:40:14" ], "originalName": "e" }, { "type": "keydown", "description": "b=>{const v=new yi(b);!v.equals(10)&&!v.equals(3)||K$t(i,e,v)}", "objectId": "-6737128020740298089.4.35827", "stack": [ "listener (file:///workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:383:2826)", "new N5i (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:32:8619)", "K (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:32:8780)", "b0 (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:384:2813)", "Yxe.r (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2126:72)", "Yxe.n (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2111:336)", "Yxe.render (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2109:24451)", "Cat.H (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2126:9844)", "Cat.t (vscode-file://vscode-app/workspace/vscode-memory-leak-finder/.vscode-test/vscode-linux-x64-1.102.0/resources/app/out/vs/workbench/workbench.desktop.main.js:2126:8377)" ], "count": 97, "originalStack": [ "file:/Users/cloudtest/vss/_work/1/s/src/vs/base/browser/markdownRenderer.ts:189:87" ], "originalName": "e" } ], "isLeak": true }After checking where the
markdownRendererconnects to theextensionFeaturesmodule, one suspicious disposable from below was discovered. The change registersrenderer.render(this.manifest)as a disposable so that it can be properly disposed.Event listeners (after)
Running the same test again with the fix in place shows no more leaking event listeners
{ "eventListeners": [], "isLeak": false }