Repository navigation
Add client ID fallback for MCP OAuth when Dynamic Client Registration fails - #255633
Merged
Merged
Conversation
Co-authored-by: TylerLeonhardt <[email protected]>
Co-authored-by: TylerLeonhardt <[email protected]>
…tDetails method Co-authored-by: TylerLeonhardt <[email protected]>
Co-authored-by: TylerLeonhardt <[email protected]>
Co-authored-by: TylerLeonhardt <[email protected]>
…ils method Co-authored-by: TylerLeonhardt <[email protected]>
- Add modal dialog before prompting for client details to explain DCR not supported - Include redirect URI information in modal dialog (http://localhost:*, https://vscode.dev/redirect) - Use shared title "Add Client Registration Details" across multi-step quick picks - Remove "please" from prompts to keep them concise - Remove unnecessary validateInput function for client secret - Improve overall user experience flow Co-authored-by: TylerLeonhardt <[email protected]>
Benjamin Pasero (bpasero)
approved these changes
Jul 13, 2025
Member
Author
|
Fixes #252892 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server doesn't support DCR, we show them this:
It won't be the common flow, so it's a little hard to articulate that you need to do go and get a client id & maybe a client secret if that's needed by the auth server... but this is a good first step to see who uses this.