fix(chat): correct file icon rendering in Files & Folders picker#255384
fix(chat): correct file icon rendering in Files & Folders picker#255384bpasero merged 8 commits intomicrosoft:mainfrom
Conversation
File icons were not displaying in the chat context Files & Folders picker while folder icons worked correctly. This was due to using iconClass instead of iconClasses property. The quick-input component has two icon rendering paths: - iconClass: applies classes to icon container element - iconClasses: applies classes to IconLabel component File icon themes require the specific CSS context provided by IconLabel, so file icons must use iconClasses to render properly. Changes: - Add iconClasses property to IChatContextPickerPickItem interface - Change FilesAndFoldersPickerPick to use iconClasses instead of iconClass - File icons now render correctly using proper DOM structure Fixes file icon display issue in chat context picker while maintaining backward compatibility with existing iconClass usage for simple codicons.
|
Just need to build vscode on my pc to verify it |
Before:
After:
I think this is ready to review. This is my first PR to vscode so please let me know how to do better, thank you very much |
|
thanks! lgtm. |
|
looks like we approved this but we never merged it. we'll get this merged for next iteration. thanks @imbant ! |
|
Ping @justschen |
There was a problem hiding this comment.
This was NOT
With the changes applied, things look good:
Thanks @imbant for the right pointers.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Thanks for fixing it! Glad it helped. Would love to learn what additional changes were needed if you have time to share and what I can do for now as a newcomer! |
|
Yeah the change in e45528a |
7 participants
File icons were not displaying in the chat context Files & Folders picker while folder icons worked correctly. This was due to using iconClass instead of iconClasses property.
The quick-input component has two icon rendering paths:
File icon themes require the specific CSS context provided by IconLabel, so file icons must use iconClasses to render properly.
Changes:
Fixes file icon display issue in chat context picker while maintaining backward compatibility with existing iconClass usage for simple codicons.