Add shellIntegrationNonce support to TerminalOptions and ExtensionTerminalOptions#253008
Merged
Add shellIntegrationNonce support to TerminalOptions and ExtensionTerminalOptions#253008
Conversation
…n flow Co-authored-by: Tyriar <[email protected]>
Co-authored-by: Tyriar <[email protected]>
Copilot
AI
changed the title
[WIP] Shell integration nonce unavailable in unknown shells and Pseudoterminal-based extension terminals
Add shellIntegrationNonce support to TerminalOptions and ExtensionTerminalOptions
Jun 30, 2025
Tyriar
approved these changes
Aug 10, 2025
Contributor
|
Verified it works for both types of options. |
aeschli
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements support for custom shell integration nonces in VS Code terminals, allowing extensions to enable shell integration features for shells that VS Code doesn't natively support.
Problem
Previously, the
VSCODE_NONCEenvironment variable was only available for VS Code's natively supported shells (bash, zsh, pwsh, etc.). This prevented extensions like Julia from implementing shell integration features because:VSCODE_NONCEenvironment variable would be setSolution
Added a new optional
shellIntegrationNonceproperty to bothTerminalOptionsandExtensionTerminalOptionsinterfaces, enabling extensions to provide their own nonce for shell integration.API Changes
Usage Example
Implementation Details
shellIntegrationNonceto VS Code's public APIVSCODE_NONCEenvironment variable even when shell integration injection fails for unsupported shellsBenefits
This enables extensions like Julia to provide the same shell integration capabilities that were previously only available for VS Code's natively supported shells.
Fixes #190253.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.