Use preserveFocus when focusing stack frames #251964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor4312
reviewed
Jun 20, 2025
| ((threadStopReason === 'instruction breakpoint' && !preserveFocus) || | ||
| (threadStopReason === 'step' && this.thread.lastSteppingGranularity === 'instruction' && !preserveFocus) || | ||
| editorService.activeEditor instanceof DisassemblyViewInput)) { | ||
| return editorService.openEditor(DisassemblyViewInput.instance, { pinned: true, revealIfOpened: true }); |
Member
There was a problem hiding this comment.
I think we should just pass the preserveFocus boolean to the options argument here
Suggested change
| return editorService.openEditor(DisassemblyViewInput.instance, { pinned: true, revealIfOpened: true }); | |
| return editorService.openEditor(DisassemblyViewInput.instance, { pinned: true, revealIfOpened: true, preserveFocus }); |
Contributor
Author
There was a problem hiding this comment.
I can include preserveFocus in the options, but that alone doesn't seem to fix the issue.
connor4312
approved these changes
Jul 8, 2025
rzhao271
approved these changes
Jul 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251241
Tested by running the reproduction steps listed in the issue.
When selecting different stack frames, the editor's focus stays on source if its focus was on source before and it stays on disassembly if its focus was on disassembly before.
When the debugger stops because of an instruction breakpoint or because of an instruction step, the focus will shift to the diassembly, but if different stack frames are inspected afterwards, you get the behavior above.