TerminalTaskSystem: Fix addtion arguments for string command #251201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
anthonykim1
reviewed
Jun 11, 2025
Contributor
Author
|
Looking forward to the approval @anthonykim1 @meganrogge |
anthonykim1
reviewed
Jun 27, 2025
Contributor
|
Not sure why the CI is failing @dylanchu otherwise LGTM Maybe we'd get a better chance if PR comes from upstream branch rather than a fork? It might just be flaky tbh |
anthonykim1
approved these changes
Jul 11, 2025
meganrogge
approved these changes
Jul 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
cmd.execmd.exe: the "/d" argument should always be the first argument if there are other arguments specified in profilescmd.exe: argument "/k" from profiles will be ignored as it conflicts with "/c"msys2.cmd&msys2_shell.cmd: "-c" will be added automatically if not specified in profilesThis should fix #169821.