Skip to content

Update copyFiles.ts #250773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mjbvz merged 4 commits into from
Jun 23, 2025
Merged

Update copyFiles.ts #250773

mjbvz merged 4 commits into from
Jun 23, 2025

Conversation

@ghLcd9dG
Copy link
Contributor

@ghLcd9dG ghLcd9dG commented Jun 5, 2025

add isoTime to markdown extension copy file destination options.
I guess many people need that (e.g., me)

@aeschli aeschli assigned mjbvz and unassigned aeschli Jun 6, 2025
DhruvTheDev1
DhruvTheDev1 reviewed Jun 6, 2025
View reviewed changes
Copy link

@DhruvTheDev1 DhruvTheDev1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall — adding isoTime is a nice touch for more readable timestamps when copying files.

mjbvz
mjbvz requested changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to include any code changes

DhruvTheDev1
DhruvTheDev1 reviewed Jun 16, 2025
View reviewed changes
Copy link

@DhruvTheDev1 DhruvTheDev1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

['isoTime', new Date().toISOString()]
Adds a variable 'isoTime' in the resolveCopyDestinationSetting function which lets users include ${isoTime} in the destination path template.

mjbvz
mjbvz requested changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@mjbvz mjbvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This also needs to be documented in for the settings. Check the markdown-language-features settings json

@DhruvTheDev1 DhruvTheDev1 mentioned this pull request Jun 17, 2025
Closed
@DhruvTheDev1
Copy link

DhruvTheDev1 commented Jun 17, 2025

I opened a follow up PR to document the added isotime variable in the setting description
Update package.nls.json #251706

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 17, 2025

Please put all the related changes into a single PR. That helps review and tracking work on the feature

@ghLcd9dG
Copy link
Contributor Author

ghLcd9dG commented Jun 20, 2025

@ghLcd9dG please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@mjbvz mjbvz enabled auto-merge June 20, 2025 16:08
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 20, 2025
Tyriar
Tyriar approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjbvz unit tests failing, might need to report the flake to the test owner?

@mjbvz mjbvz merged commit c663424 into microsoft:main Jun 23, 2025
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Tyriar Tyriar Tyriar approved these changes

@mjbvz mjbvz mjbvz approved these changes

+1 more reviewer

@DhruvTheDev1 DhruvTheDev1 DhruvTheDev1 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mjbvz mjbvz

Labels

triage-needed

Projects

None yet

Milestone

June 2025

Development

Successfully merging this pull request may close these issues.

5 participants

@ghLcd9dG @DhruvTheDev1 @mjbvz @Tyriar @aeschli