Fix #250737, Match count result overflow in Notebook findWidget #250738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
hi, @osortega Can you help me review the code? |
Yoyokrazy
approved these changes
Jun 10, 2025
Collaborator
Yoyokrazy
left a comment
Yoyokrazy
left a comment
There was a problem hiding this comment.
Thank you for the community PR! This looks good to me 👍
With the additional CSS that was brought in via the earlier PR you mentioned, and (somewhat) recent changes to the starting width of the notebook find widget, this seems like a good fix.
aiday-mar
approved these changes
Jun 10, 2025
This was referenced Jun 10, 2025
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before fix:
After fix:
I saw that the
minWidthhere was modified in this #147398 . Now after revising back to theminWidth, it seems that there won't be any problems now either.