Skip to content

Fix #24971. PowerShell Extension .bat & .exe Syntax Highlighting Error#24973

Merged
mjbvz merged 2 commits intomicrosoft:masterfrom
thomasrayner:master
Apr 18, 2017
Merged

Fix #24971. PowerShell Extension .bat & .exe Syntax Highlighting Error#24973
mjbvz merged 2 commits intomicrosoft:masterfrom
thomasrayner:master

Conversation

@thomasrayner
Copy link
Member

@thomasrayner thomasrayner commented Apr 18, 2017

By changing the regular expression as per this PR, .bat and .exe files will be properly highlighted.

Code to reproduce

something.bat 
ipconfig.exe
Import-Module AzureRM.Backup
Import-Module AzureRm.Batch 
Import-Module AzureRm.Exefake
Import-Module AzureRM.Cdn
21jumpstreet.bat

Results before applying this change

image

Results after applying this change

image

@thomasrayner
Fix #24971. Change regular expression in PowerShell extension syntax …
db98104 
…highlighting to properly highlight .bat and .exe files
@mention-bot
Copy link

mention-bot commented Apr 18, 2017

@ThmsRynr, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @daviwil to be potential reviewers.

@msftclas
Copy link

msftclas commented Apr 18, 2017

@ThmsRynr,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

daviwil
daviwil approved these changes Apr 18, 2017
View reviewed changes
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thomasrayner
Fixed error that would include whitespace or other chars
c2fa63f 
Changed regex to correctly identify a . instead of any character.
@mjbvz mjbvz merged commit da6cbf0 into microsoft:master Apr 18, 2017
@mjbvz mjbvz added this to the April 2017 milestone Apr 18, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@daviwil daviwil daviwil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

April 2017

Development

Successfully merging this pull request may close these issues.

5 participants

@thomasrayner @mention-bot @msftclas @daviwil @mjbvz