Use international number formatter to display quota percentage #248038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use international number formatter
lramos15
added
the
candidate
sbatten
reviewed
May 2, 2025
| if (quota.unlimited) { | ||
| quotaValue.textContent = localize('quotaUnlimited', "Included"); | ||
| } else if (quota.overageCount) { | ||
| quotaValue.textContent = localize('quotaDisplayWithOverage', "+{0} requests", quota.overageCount); |
Member
There was a problem hiding this comment.
do we want to have the same formatting for overage?
Member
Author
There was a problem hiding this comment.
I wanted to minimize the change, and since overage comes directly from the limiter I don't think we will have this massive decimal overflow issue that percentage has. I'll add it though just to be safe
Member
There was a problem hiding this comment.
Fyi I will port that part of the change over to main
sbatten
approved these changes
May 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use international number formatter
Fix #248037