Use international number formatter to display quota percentage #248030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
approved these changes
May 2, 2025
connor4312
approved these changes
May 2, 2025
lramos15
added a commit
that referenced
this pull request
May 2, 2025
Use international number formatter
lramos15
added a commit
that referenced
this pull request
May 2, 2025
* Use international number formatter to display quota percentage (#248030) Use international number formatter * Format overage too * More polish * Bad line
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows the number format according to the locale
cc @connor4312
We don't do this in many of the places we show numbers. I'm wondering if we should be and if so if there should be a utility that respects the user's VS code locale settings? Is it weird to do this just in one place?