Add zenMode.hideActivityBar option#24499
Merged
isidorn merged 2 commits intomicrosoft:masterfrom Apr 12, 2017
lifez:option-keep-activity-bar-in-zen-mode
Merged
Add zenMode.hideActivityBar option#24499isidorn merged 2 commits intomicrosoft:masterfrom lifez:option-keep-activity-bar-in-zen-mode
isidorn merged 2 commits intomicrosoft:masterfrom
lifez:option-keep-activity-bar-in-zen-mode
Conversation
Contributor
Author
|
Could anyone guide me how to test this function |
isidorn
reviewed
Apr 11, 2017
| 'zenMode.hideActivityBar': { | ||
| 'type': 'boolean', | ||
| 'default': true, | ||
| 'description': nls.localize('zenMode.hideActivityBar', "Controls if turning on Zen Mode also hides the activitybar bar at the left of the workbench.") |
Collaborator
There was a problem hiding this comment.
Please use 'activity bar' not 'activitybar' in the description
isidorn
reviewed
Apr 11, 2017
| this.setSideBarHidden(true, true).done(undefined, errors.onUnexpectedError); | ||
|
|
||
| this.setActivityBarHidden(true, true); | ||
| this.setActivityBarHidden(false, false); |
Collaborator
There was a problem hiding this comment.
This line is not needed. this.setActivityBarHidden(false, false);
If the setting is not true we simply should not do anything
Collaborator
|
@lifez thank you for your PR, I have commented twice in the commit. Please address those comments and then we can merge in this PR. |
Contributor
Author
|
@isidorn done! |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to #23611