Fix webview sizing when zooming#24465
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Apr 11, 2017
Merged
Conversation
|
@mjbvz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken and @joaomoreno to be potential reviewers. |
Fixes microsoft#5745 **Bug** When zooming in or out, webview contents are not properly sized to fill their parent element **Fix** Add a layout method on the webview that manually sets the contents sizes
bpasero
approved these changes
Apr 11, 2017
Member
bpasero
left a comment
bpasero
left a comment
There was a problem hiding this comment.
Seems to work, nice idea. Downside is a bit more flicker and slugginess when resizing parts.
Maybe we could make this conditional and only enable the custom layout when the workbench is actually zoomed?
Member
|
nice. didn't now that exists. lets hope it doesn't break sql ;-) |
jrieken
approved these changes
Apr 11, 2017
RishabhKothaari
pushed a commit
to RishabhKothaari/vscode
that referenced
this pull request
Apr 11, 2017
Fixes microsoft#5745 **Bug** When zooming in or out, webview contents are not properly sized to fill their parent element **Fix** Add a layout method on the webview that manually sets the contents sizes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5745
Bug
When zooming in or out, webview contents are not properly sized to fill their parent element
Fix
Add a layout method on the webview that manually sets the content size