Fixed wrong negation in the _shouldRenderHint logic.#242479
Merged
DonJayamanne merged 6 commits intomicrosoft:mainfrom Dec 11, 2025
Merged
Fixed wrong negation in the _shouldRenderHint logic.#242479DonJayamanne merged 6 commits intomicrosoft:mainfrom
DonJayamanne merged 6 commits intomicrosoft:mainfrom
Conversation
When activeEditor.isDisposed, the hint should not be rendered.
…age" in the empty cell hint. This overrides the default language selection command with a cell-specific command that takes into account the kernel's supported languages.
Contributor
Author
|
@microsoft-github-policy-service agree company="Google" |
1 similar comment
Contributor
Author
|
@microsoft-github-policy-service agree company="Google" |
…ct language" in the empty cell hint." This reverts commit c3f5a65.
Contributor
Author
|
The last commit was added accidentally and has been reverted. |
DonJayamanne
approved these changes
Dec 10, 2025
Tyriar
approved these changes
Dec 10, 2025
DonJayamanne
added a commit
that referenced
this pull request
Dec 12, 2025
This reverts commit 5dab780.
DonJayamanne
added a commit
that referenced
this pull request
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When activeEditor.isDisposed, the hint should not be rendered.
Fixes: #242478